[Bug 230512] Review Request: viewvc- Browser interface for CVS and SVN version control repositories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: viewvc-  Browser interface for CVS and SVN version control repositories


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230512





------- Additional Comments From bjohnson at symetrix.com  2007-03-02 19:29 EST -------
This comment can be removed since you only have the relevent line anyway:
# sitelib for noarch packages, sitearch for others (remove the unneeded one)

W: viewvc setup-not-quiet
You should use -q to have a quiet extraction of the source tarball, as this
generate useless lines of log ( for buildbot, for example )

W: viewvc macro-in-%changelog python_sitelib
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

This is triggered by your changelog comment in 1.0.3-3.  Change
"%{python_sitelib}" to "%%{python_sitelib}".

W: viewvc mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 61)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.