[Bug 230738] Review Request - jwm - Very light window manager
bugzilla at redhat.com
bugzilla at redhat.com
Sun Mar 4 15:56:04 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request - jwm - Very light window manager
Alias: jwm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230738
pertusus at free.fr changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pertusus at free.fr
------- Additional Comments From pertusus at free.fr 2007-03-04 10:56 EST -------
(In reply to comment #1)
> You should use the macro %{buildroot} instead of $RPM_BUILD_ROOT.
> You souldn't mix macro and variable style.
>
> "You should pick a style and use it consistently throughout your packaging."
>
(http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf)
In the spec file $RPM_BUILD_ROOT is used consistently, no need to use
%{buildroot}.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list