[Bug 194280] Review Request: kdebindings: KDE/DCOP bindings to non-C++ languages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdebindings: KDE/DCOP bindings to non-C++ languages


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194280





------- Additional Comments From kevin at tummy.com  2007-03-05 23:35 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
d26b5f54f062b765a949d66657c2ab3c  kdebindings-3.5.6.tar.bz2
d26b5f54f062b765a949d66657c2ab3c  kdebindings-3.5.6.tar.bz2.1
See below - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
OK - .la files are removed.

Pending - Package compiles and builds on at least one arch.
Pending - Package has no duplicate files in %files.
Pending - Package doesn't own any directories other packages own.
Pending - Package owns all the directories it creates.
Pending - No rpmlint output.
Pending - final provides and requires are sane

SHOULD Items:

Pending - Should build in mock.
Pending - Should build on all supported archs
Pending - Should function as described.
See below - Should have subpackages require base package with fully versioned
depend.
OK - Should have dist tag
OK - Should package latest version

Issues/comments:

1. URL might be better as:
http://developer.kde.org/language-bindings/ ?

2. Should we really be using 'Conflicts: sip, PyQt, PyKDE' here?
If it's replacing those, shouldn't it be using Obsoletes/Provides?
Or are they totally different with file conflicts? Any way to avoid
the conflicts if so?

3. Should the subpackages all just have the same description, which 
would just be the summary repeated?

4. --disable-final appears in a debug conditional, and outside it...
one should be removed?

5. Is this needed anymore? All currently supported fedoras have
a newer version than this I think...

%if "%{?perl_ver}" < "5.8.3"
# hack for older perl(MakeMaker) that doesn't grok DESTDIR
%define perl_install_root PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
%endif

6. I'm getting a build failure in mock...

checking for glib-config... no
checking for GLIB - version >= 1.2.6... no
*** The glib-config script installed by GLIB could not be found
*** If GLIB was installed in PREFIX, make sure PREFIX/bin is in
*** your path, or set the GLIB_CONFIG environment variable to the
*** full path to glib-config.
checking for gtk-config... no
checking for GTK - version >= 1.2.6... no
*** The gtk-config script installed by GTK could not be found
*** If GTK was installed in PREFIX, make sure PREFIX/bin is in
*** your path, or set the GTK_CONFIG environment variable to the
*** full path to gtk-config.
checking whether to use kmdi lib from kdelibs... yes
checking whether to use the knewstuff lib from kdelibs... yes
checking for Java... checking for pkg-config... /usr/bin/pkg-config
configure: error: javah not found under /usr/lib/jvm/java-1.4.2/bin. javac was
found though! Use --with-java or --without-java.
error: Bad exit status from /var/tmp/rpm-tmp.76189 (%build)

The glib-devel/gtk+-devel BuildRequires need to be commented back in?
Or something needs to be adjusted so they aren't needed anymore?
Not sure about the java error...

7. Should the decopperl subpackage have a
Requires: %{name} = %{version}-%{release}
Or does it not need the main package around?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.