[Bug 200236] Review Request: kdeaddons: K Desktop Environment - Plugins

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdeaddons: K Desktop Environment - Plugins


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200236


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(gauret at free.fr)   |




------- Additional Comments From gauret at free.fr  2007-03-06 08:54 EST -------
Needs work:
* The package should contain the text of the license (COPYING-DOCS)
  (wiki: Packaging/ReviewGuidelines)
* Scriptlets: missing "Require(post): xdg-utils" and "Require(postun):
xdg-utils" (on kdeaddons and kdeaddons-atlantikdesigner)
* As kdeaddons ships icons in the hicolor directory, it should have "Requires:
hicolor-icon-theme" (for both binary packages also)
https://www.redhat.com/archives/fedora-extras-list/2006-September/msg00282.html

Details:
* mixed-use-of-spaces-and-tabs (spaces: line 97, tab: line 5)
* privacy patch is chmod 744


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.