[Bug 227107] Review Request: plexus-velocity-1.1.2-2jpp - Plexus Velocity Component

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: plexus-velocity-1.1.2-2jpp - Plexus Velocity Component


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227107


tbento at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|tbento at redhat.com           |dbhole at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From tbento at redhat.com  2007-03-08 14:02 EST -------
> X * is it legal for Fedora to distribute this?
>   - OSI-approved
>   Unable to verify license of project. Please send note to user mailing list
>   to clarify:
> 
>  http://plexus.codehaus.org/plexus-components/plexus-velocity/mail-lists.html

I've sent an email and someone was kind enough to respond.  Plexus-velocity is
under the MIT license, but Velocity itself is under the Apache Software license.

> X * license field matches the actual license.
>     Unable to verify license of project. Please send note to user mailing list to
>     clarify:
> 
>     http://plexus.codehaus.org/plexus-components/plexus-velocity/mail-lists.html

See above.
 
> X * license text included in package and marked with %doc
>     Included license is from the maven castor plugin. This project has no
>     license.txt included in the source, and the file should therefore be 
>     removed.

I've removed the %doc line in %files.

> X * BuildRequires are proper
>   - builds in mock will flush out problems here
>  Does not build in mock

Fixed.

> X * package should build in mock
>     Does not build

Now builds in mock.


Here is the link to the updated spec file and source rpm:

SPEC FILE:
https://tbento.108.redhat.com/files/documents/177/273/plexus-velocity.spec

SOURCE RPM:
https://tbento.108.redhat.com/files/documents/177/274/plexus-velocity-1.1.2-2jpp.1.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.