[Bug 231263] Review Request: xml-commons-apis12 - JAXP 1.2, DOM 2, SAX 2.0.1, SAX2-ext 1.0 apis

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xml-commons-apis12 - JAXP 1.2, DOM 2, SAX 2.0.1, SAX2-ext 1.0 apis


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231263


mwringe at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(mwringe at redhat.com|
                   |)                           |




------- Additional Comments From mwringe at redhat.com  2007-03-09 17:59 EST -------
(In reply to comment #3)
> Please remove the second BuildRoot.

removed
 
> What is epocj in ...
> Provides:       %{name}-apis-javadoc = %{epocj}:%{apis_version_1_2}
> ?

oops, spelling mistake, change to epoch

> The %setup section includes...
> 
> # remove all binary libs and prebuilt javadocs
> rm -rf `find . -name "*.jar" -o -name "*.gz"`
> 
> The sources don't include any .jar or .gz files, so I think this could be removed.

removed

> Are we adding Red Hat copyright notices to these files (seeing as JPP has them).
I don't think I have seen them outside of the jpp packages.
> 
> I think this should be ready to go once these are taken care of / answered.
> 
> Thanks!
> 
> 
New Files uploaded there:
https://mwringe.108.redhat.com/files/documents/175/285/xml-commons-apis12.spec
https://mwringe.108.redhat.com/files/documents/175/286/xml-commons-apis12-1.2.04-0jpp.1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.