[Bug 222593] Review Request: php-pear-Image-Graph - Displays numerical data as a graph/chart/plot

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Image-Graph - Displays numerical data as a graph/chart/plot
Alias: pear-Image-Graph

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222593


Fedora at FamilleCollet.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From Fedora at FamilleCollet.com  2007-03-10 10:25 EST -------
REVIEW :
* source files match upstream:
4e3f338314fe0754970a896686875a5e  Image_Graph-0.7.2.tgz
* package meets naming and
packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct (second form).
* license field matches the actual license.
* license is open source-compatible (LGPL).
* latest version is being packaged (0.7.2)
* BuildRequires are proper.
* %clean is present.
* package builds in mock (FC6).
* package installs properly
* rpmlint is silent.
* final provides are sane:
php-pear(Image_Graph) = 0.7.2
php-pear-Image-Graph = 0.7.2-1.fc7
=> final Requires are sane:
php-pear(Image_Canvas) >= 0.3.0
php-pear(Numbers_Roman)  
php-pear(Numbers_Words)  
php-pear(PEAR)  
* %check is not present; 
* owns the directories it creates
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear install)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

Tests works well and produce nice charts ;)
only a font problem (Arial) with tests/freetype.php

Most Examples works well.

To avoid some warnign, Should change
 find docdir -exec sed -i 's/\r//' {} \;
To 
 find docdir -type f -exec sed -i 's/\r//' {} \;

* APPROVED *

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.