[Bug 208034] Review Request: HippoDraw - Interactive and Python scriptable data analysis application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: HippoDraw - Interactive and Python scriptable data analysis application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034





------- Additional Comments From paul_kunz at slac.stanford.edu  2007-03-10 18:12 EST -------
shebang taken out of pyfits.py

> * Requires
>  - not fixed at all. Please check my previous comment 22.
>    NOTE: Here what I mean is that you have to add something
>    to "Requires", not "BuildRequires".

   I think I fixed it correctly knowing what is needed at runtime for the
application.   Which item do you think is wrong?

>  - Still two files are under /usr/share/doc/HippoDraw/.
fixed

> - Category "DataVisualization" is not valid (please check comment 25)
removed.
>  - Category "Science" is valid, so this can be left as is.
>    However, currenly no HippoDraw entry appear in my GNOME menu.
>    Please check:
>    /etc/xdg/menus/applications.menu 
>    and add a category which can be found in the menu file above
>    so that HippoDraw entry can appear on GNOME menu.

Only category I could find which I think is a bit of a strech is Graphics.  I
checked under GNOME that it works.   Under KDE, it appears under "Science &
Math" altho I don't know why exactly.

> checking for /usr/local/include/wcslib/wcs.h... no
> checking for no/libwcs.a... no
> configure: WARNING: WCSLIB not found
> ----------------------------------------------------
>  - Perhaps this can be enabled by libwcs-devel?

The directory structure and even name of the key header file is different in the
rpm than when one does an install in /usr/local/ from source.   It would
complicate the sources and configure script to support both.   Thanks for
pointing out that it exists.

> * Build order
>  - By the way, can it be moved to %build stage to
>    make doxygen called to build documentation?

That could be done if you think it is important enough.


>* Build log
>  - Can the following(s) be ignored?
----------------------------------------------------
> Generating docs for filRenderer type: "gif" not recognized. 
> Use one of: canon cmap cmapx dia dot fig gtk hpgl imap ismap mif mp
> pcl pdf pic plain plain-ext png ps ps2 svg svgz vtx xdot xlib
> Problems running dot. Check your installation!

I don't see that message on FC6 with 

rpm -qf /usr/bin/dot
graphviz-2.8-5.fc6

If dot is not generating .gif files, then the documentation in package
HippoDraw-devel-docs are not going to look right.


> * Changelog
>  - By the way, why do you use the mail address in the changelog
>    which differs from your bugzilla entry?

I'm using rpm mode in emacs to generate the entries.   It picks up my userid
on my laptop that I'm using for development.   You'll note the machine name
changes depending on whether I'm at work or at home due to different DHCP
server. Should I manually fix all of them?

Fix files...

SRPMS ftp://ftp.slac.stanford.edu/users/pfkeb/hippodraw/HippoDraw-1.19.5-1.src.rpm
SPEC  ftp://ftp.slac.stanford.edu/users/pfkeb/hippodraw/HippoDraw.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.