[Bug 222598] Review Request: php-pecl-radius - Radius client library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-radius - Radius client library
Alias: php-pecl-radius

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222598





------- Additional Comments From Fedora at FamilleCollet.com  2007-03-11 09:52 EST -------
I finally succeed to install a local radius server and to have a working test
for this extension, so, 

=== REVIEW ===
:) source files match upstream:
3d48ccb9486b9e8839d814d7ff318091  radius-1.2.4.tgz
:) package meets naming and packaging guidelines.
:( specfile is properly named, is cleanly written and uses macros consistently.
=> see comment #4
:) dist tag is present.
:) build root is correct (second form).
:) license field matches the actual license.
:) license is open source-compatible (BSD).
:) latest version is being packaged (1.2.4)
:) BuildRequires are proper.
:) %clean is present.
:) package builds in mock (FC6).
:) package installs properly
:) rpmlint is silent.
:) final provides are sane:
config(php-pecl-radius) = 1.2.4-1.fc7
php-pecl(radius) = 1.2.4-1.fc7
radius.so()(64bit)  
php-pecl-radius = 1.2.4-1.fc7
:/ final Requires are sane:
=> see comment # 3
:) %check is not present; 
:) owns the directories it creates
:) no duplicates in %files.
:) file permissions are appropriate.
:) no scriplet
:) code, not content.
:) documentation is small, so no -docs subpackage is necessary.
:) %docs are not necessary for the proper functioning of the package.

Don't know if "release" is need in virtual provide 'php-pecl(radius)' ? 
perl and php-pear virtual provide never used it.

Should : comment #3
Must: comment #4


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.