[Bug 230140] Review Request: SILLY - Simple and easy to use library for image loading

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SILLY - Simple and easy to use library for image loading


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230140





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-11 13:32 EST -------
Well, almost okay.
For 0.1.0-1:

* Timestamps
  - This package tries to install 
    * some text files such as header files (in -devel)
    and keeping timestamps on these files are recommended.
    Perhaps
------------------------------------------------
make install DESTDIR=%{buildroot} INSTALL="%{__install} -p"
------------------------------------------------
    will work

* Provides
  - By the way, why do you want the following?
------------------------------------------------
Provides:       silly = %{version}-%{release}
------------------------------------------------

* Source
  - Please check:
    http://fedoraproject.org/wiki/Packaging/SourceURL

* Warning
  - Unless they are _very_ noisy, please don't suppress warnings.

* sed usage
  - Perhaps
-------------------------------------------------
%{__sed} -i 's|\(GENERATE_MAN[ \t][ \t]*= \)NO|\1YES|' Doxyfile
-------------------------------------------------
    would be better. You don't have to count the number of spaces.

* Encodings
  - Please change the encoding of the following to UTF-8.
-------------------------------------------------
./AUTHORS ISO-8859-1
-------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.