[Bug 231753] Review Request: perl-DBD-Mock - Mock database driver for testing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DBD-Mock - Mock database driver for testing


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231753


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-03-12 03:23 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5070cfde75059aa2273e09b39c4d2d5f  DBD-Mock-1.34.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ./Build test
t/000_basic............................ok
t/001_db_handle........................ok
t/002_dr_handle........................ok
t/003_db_can_connect...................ok
t/004_misc_mock_attr...................ok
t/005_db_parser........................ok
t/006_prepare_cached...................ok
t/007_mock_attribute_aliases...........ok
t/008_db_connect_cached................ok
t/009_info.............................ok
t/010_rollback.........................ok
t/011_st_execute_empty.................ok
t/012_st_handle........................ok
t/013_st_execute_bound_params..........ok
t/014_st_execute_pass_params...........ok
t/015_st_fetch_records.................ok
t/016_mock_add_resultset_test..........ok
t/017_st_can_connect...................ok
t/018_mock_statement_track.............ok
t/019_mock_statement_track_iterator....ok
t/020_db_pool..........................ok
t/021_DBD_Mock_Session.................ok
t/022_DBD_Mock_Session_bound_params....ok
t/023_statement_failure................ok
t/024_selcol_fetchhash.................ok
t/025_mock_last_insert_id..............ok
t/998_pod..............................ok
t/999_pod_coverage.....................ok
t/bug_0001.............................ok
All tests successful.
Files=29, Tests=572,  3 wallclock secs ( 2.16 cusr +  0.37 csys =  2.53 CPU)

+ Provides: perl(DBD::Mock) = 1.34 perl(DBD::Mock::Pool)
perl(DBD::Mock::Pool::db) perl(DBD::Mock::Session)
perl(DBD::Mock::StatementTrack) perl(DBD::Mock::StatementTrack::Iterator)
perl(DBD::Mock::db) perl(DBD::Mock::dr) perl(DBD::Mock::st)


APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.