[Bug 231005] gnome-vfs2-obexftp: ObexFTP filesystem support for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: gnome-vfs2-obexftp: ObexFTP filesystem support for GNOME


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231005





------- Additional Comments From bnocera at redhat.com  2007-03-12 07:15 EST -------
(In reply to comment #2)
> Initial comments from just skimming the srpm, possibly a full review later
> unless someone beats me to it:
> 
> - --with-compile-warnings=no to configure seems to be a no-op

configure options are also passed to subconfigures (in this case osso-gwobex).
Not adding this option results in this bug:
https://maemo.org/bugzilla/show_bug.cgi?id=1137

> - --disable-dependency-tracking to configure would result in cleaner build
> output and possibly slightly faster build.

Done.

> - License file missing from %doc - is the package GPL or LGPL?  Both files are
> included in the upstream tarball, but it seems to me that this is LGPL and thus
> COPYING.LIB should only be included.  Upstream could be interested in clarifying
> this in future releases.

I ping'ed James Henstridge about it.

> - Cosmetics: both %buildroot and $RPM_BUILD_ROOT used, should stick with one

Fixed.

> - Doesn't parallel build (make %{?_smp_mflags}) work?

Should do, fixed.

> - %makeinstall used - doesn't 'make install DESTDIR=$RPM_BUILD_ROOT' work?

Should do, fixed.

> - If hcid needs to be started with -x using the bluetooth init script, a bug
> should be opened against bluez-utils asking to make it possible to set hcid
> options in a /etc/sysconfig/* snippet, and have that bug block this one.  Or did
> you mean starting hcid some other way?

Right now, it means editing /etc/init.d/bluetooth and modifying the parameters.
The "-x" means that it enables experimental features in hcid's D-Bus support,
and probably wouldn't be supported by us. I intend on blocking this particular
package until we can get a version of gnome-vfs-obexftp that works out of the box.

Updated packages at:
http://people.redhat.com/bnocera/gnome-vfs2-obexftp/gnome-vfs2-obexftp-0.2-2.src.rpm
http://people.redhat.com/bnocera/gnome-vfs2-obexftp/gnome-vfs2-obexftp.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.