[Bug 225345] Review Request: kodos - Visual regular expression editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kodos - Visual regular expression editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345


orion at cora.nwra.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |fedora-review-,
                   |                            |needinfo?(icon at fedoraproject
                   |                            |.org)




------- Additional Comments From orion at cora.nwra.com  2007-03-12 12:49 EST -------
Good:

- rpmlint checks return:

    *


- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime

Worrisome:

- There is no license/copyright/author information in the source files
themselves.  Please ping upstream about getting this added.  Not a blocker per
se, since the project clearly inteads to be GPLv2.

Fix:

- No need for X-Fedora in desktop-file-install
- No need for update-desktop-database - no MimeType key in .desktop file
(http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28update-desktop-database%29#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.