[Bug 225400] Review Request: tetrinetx - The GNU TetriNET server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tetrinetx - The GNU TetriNET server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225400





------- Additional Comments From faucamp at csir.co.za  2007-03-13 05:58 EST -------
New build:
Spec URL: http://www.snoekie.com/rpm/tetrinetx.spec
SRPM URL: http://www.snoekie.com/rpm/tetrinetx-1.13.16-2.src.rpm

Changes:
- Cleaned up sed scripts in %prep
- Replaced config.h patch with sed script in order to support RPM macros
- Removed trademarked names from %%description

(In reply to comment #3)
> tarball. It seems that your cat/sed command in the spec is screwing it up. Use

Fixed, thanks for the pointer.

> In the build log I get:
> warning: File listed twice: /etc/tetrinetx/game.conf

Oops! Fixed. :-)

> Speaking of config files, do note that the config_dir patch hardcodes the
> location. There at least needs to be a comment in the spec, if someone moved
> %{_sysconfdir} they would want to know why it didn't go with.

I decided to remove the patch and rather do this in the spec file itself using
macros, solving this potential issue.

> As much as I also like searching on tetris, I want to avoid the trademark. You
> can get a second opinion on this, but I'd rather not use that term.

Agreed. Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.