[Bug 227080] Review Request: maven-doxia-1.0-0.a7.3jpp - Doxia is a content generation framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: maven-doxia-1.0-0.a7.3jpp - Doxia is a content generation framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227080


tbento at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|tbento at redhat.com           |dbhole at redhat.com




------- Additional Comments From tbento at redhat.com  2007-03-13 16:35 EST -------
> X * verify source and patches (md5sum matches upstream, know what the patches do)
>   - if upstream doesn't release source drops, put *clear* instructions on
>     how to generate the the source drop; ie. 
>    # svn export blah/tag blah
>    # tar cjf blah-version-src.tar.bz2 blah
> 
>   Tar command is incorrect. Should be: tar czf maven-doxia-1.0a7.tar.gz
maven-doxia/

Changed it to:  tar czf maven-doxia-1.0.a7-src.tar.gz maven-doxia/
 
> X * rpmlint on <this package>.srpm gives no output
>   - justify warnings if you think they shouldn't be there
>   W: maven-doxia non-standard-group Development/Java
>   W: maven-doxia no-documentation
>   W: maven-doxia non-standard-group Development/Java
>   W: maven-doxia mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 47)
> 
>   First 3 are OK. Last needs to be fixed.

Fixed.

> X * summary should be a short and concise description of the package
>   Summary should be: 'Content generation framework'

Fixed.

 
> X * config files should usually be marked with %config(noreplace)
>   /etc/maven/fragments/maven-doxia is not a config file and should not be
>   marked so.

Fixed.
 
> X * package should own all directories and files
>   Change:
> 
> %if %{with_maven}
> [...]
> %if %{with_maven}

Fixed.

Here are the links to the updated spec file and source rpm:
SPEC FILE:
https://tbento.108.redhat.com/files/documents/177/261/maven-doxia.spec
SOURCE RPM:
https://tbento.108.redhat.com/files/documents/177/262/maven-doxia-1.0-0.1.a7.3jpp.1.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.