[Bug 229910] Review Request: Conmux - Console Multiplexor, abstracts how to connect via backend drivers.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Conmux - Console Multiplexor, abstracts how to connect via backend drivers.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229910


jwilson at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |




------- Additional Comments From jwilson at redhat.com  2007-03-15 11:13 EST -------
(In reply to comment #21)
> ref 
> >* source files match upstream: n/a, its an svn checkout
> As far as I have understood (please correct me if I am wrong) here "n/a" is not
> correct: the reviewer is supposed to do a svn checkout of the same tag
> (instructions for that should be included as comment in the spec) and compare
> with the file included in the src.rpm. If not the tar.gz, at least a diff -r
> should coincide...

I believe you're correct. I was thinking n/a, since there's no upstream tarball
to grab, but yeah, diff'ing svn checkouts should be done in place of tarball
checksumming.

$ diff -r conmux conmux-r493
Only in conmux-r493/drivers: .svn
Only in conmux-r493/examples: .svn
Only in conmux-r493/helpers: .svn
Only in conmux-r493: .svn

Bill's tarball has the .svn dirs removed, which is fine, and everything else
appears to match.

Went ahead and dropped the FE-NEEDSPONSOR flag too.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.