[Bug 212003] Review Request: mugshot - Companion software for mugshot.org

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mugshot - Companion software for mugshot.org


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212003





------- Additional Comments From green at redhat.com  2007-03-15 20:04 EST -------
(In reply to comment #12)
> OK, here's a new version with updated licensing (the package has also grown
> some new build dependencies, but other than that I don't think the spec file
> has changed significantly.)

Thanks Owen.  I'll go through this carefully tonight or tomorrow.  In the
meanwhile, I can suggest a couple of changes.
1. Configure with --disable-static.  The current package includes .a and .la
files for the firefox thingy.  AFAICT these aren't needed and shouldn't be
installed.
2. Add "%config(noreplace)" in the %files section before the schema file like so...
%config(noreplace) %{_sysconfdir}/gconf/schemas/*.schemas
These changes silence rpmlint.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.