[Bug 231758] Review Request: perl-Workflow - Simple, flexible system to implement workflows

bugzilla at redhat.com bugzilla at redhat.com
Sat Mar 17 16:35:57 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Workflow - Simple, flexible system to implement workflows
Alias: perl-Workflow

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231758





------- Additional Comments From cweyl at alumni.drew.edu  2007-03-17 12:35 EST -------
(In reply to comment #3)
> Your package is requiring perl(Data::UUID). This seems to be problematic which
> is why I filtered the requirement from my version.
> The license.txt for Data::UUID states:
> 
> "The license under which this code was originally released is unknown, although
> its release has been interpreted as its release under an open source license.
> Attempts to contact the original author are underway. -- rjbs, 2006-11-14"
> 
> I'd suggest you do filter that requirement as it is optional according to the
> readme. Alternatively, review my package. :D Less work for you.

Data::UUID I didn't worry about too much -- it's in extras, so presumptively the
license is OK.  If a package license is under question, then a bug should be
filed, an audit conducted, etc; otherwise I'm going to trust, in good faith, the
reviewer, packager, and "rjbs" :) got it right.

> About the docs, I solved that problem by just running tar and gzip on the
> example file and packaging that tar.gz file.

Yeah, I've never actually been a fan of that...  if the docs are too large to
reasonably keep with the base package, then a -docs subpackage is in order.  The
point is well taken though -- looking back at the package, it's ~400k installed,
~220k of which is %doc.  So, that's a large percentage of the package taken up
by %doc, but still a fairly small amount of disk space overall.  I could easily
be talked into splitting them out into -docs.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list