[Bug 221084] Review Request: dkms - Dynamic Kernel Module Support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dkms - Dynamic Kernel Module Support


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221084





------- Additional Comments From mebrown at michaels-house.net  2007-03-19 12:16 EST -------
Review Summary:

MUST fix:
* hardcoded dir names. doesnt use macros for dir names.

SHOULD fix:
* TIMESTAMPS: consider "install -p", "mv -p", and "cp -p" in %install and
scriptlets.
* no tranlated summary/descriptions (acceptable)

Need to fix rpmlint errors.

The dkms_dbversion is being set 0755 due to %attr() on /var/lib/dkms. Probably
should make /var/lib/dkms a %dir, and separately list dkms_dbver.


SUMMARY: approved with the above changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.