[Bug 232710] Review Request: eclipse-sdk-nls - Eclipse language packs for eclipse-sdk
bugzilla at redhat.com
bugzilla at redhat.com
Mon Mar 19 21:31:00 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: eclipse-sdk-nls - Eclipse language packs for eclipse-sdk
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232710
------- Additional Comments From klee at redhat.com 2007-03-19 17:30 EST -------
MUST:
X verify source and patches (md5sum matches upstream, know what the patches do)
- the md5sums of NLpack1-eclipse-SDK-3.2.1-gtk.zip and
NLpack2a-eclipse-SDK-3.2.1-gtk.zip don't match my existing downloads from
upstream. I'm re-downloading to verify. The other two are fine.
X skim the summary and description for typos, etc.
-> see comments above
Done
X specfile is legible
- see comments above.
Done
X BuildRequires are proper
- see comments above
Done
X summary and description are fine
- see comments above
Done
X make sure lines are <= 80 characters
- two of the lines in the nlspackager app call have extra spaces that put
them over 80 characters
Done
X package owns all directories and files
- package needs to Require eclipse-rcp
Done
? verify the final provides and requires of the binary RPMs
. I have yet to do this
? run rpmlint on the binary RPMs
. I have yet to do this
? package should build in mock
. haven't tried but I don't anticipate any problems
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list