[Bug 232423] Review Request: perl-Class-Std - Support for creating standard "inside-out" classes

bugzilla at redhat.com bugzilla at redhat.com
Fri Mar 23 11:50:34 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-Std - Support for creating standard "inside-out" classes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232423


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-03-23 07:50 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
dc01fecfc8d5886e41d2e8bc2f29a7a2  Class-Std-v0.0.8.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is Successful.
t/00.load..............# Testing Class::Std v0.0.8
ok
t/access...............ok
t/access_automethod....ok
t/access_name..........ok
t/automethod...........ok
t/begin-coercion.......ok
t/coercions............ok
t/cumulative...........ok
t/dump.................ok
t/perlattrs............ok
t/pod-coverage.........ok
t/pod..................ok
t/runtime..............ok
t/simple...............ok
t/start................ok
All tests successful.
Files=15, Tests=276,  2 wallclock secs ( 0.99 cusr +  0.19 csys =  1.18 CPU)
+ Provides: perl(Class::Std) perl(Class::Std::SCR)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list