[Bug 233695] Review Request: Pyclutter - Python modules that allow you to use the Clutter toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Pyclutter - Python modules that allow you to use the Clutter toolkit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233695


dcm at acm.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcm at acm.org




------- Additional Comments From dcm at acm.org  2007-03-24 02:42 EST -------
I am not an official package maintainer yet, but here is my "pre-review":

* You need to change your use of %{python_sitelib} to %{python_sitearch} since
the module is architecture-specific.  This caused the rpmbuild to fail on my
x86_64 for example.  Also, you can remove the unneeded python_sitelib definition
from the top of the file.

* The _clutter.la libtool file should be removed from the install.

* The INSTALL file should be removed.

* Consider adding:
INSTALL="%{__install} -c -p"
to the make install command line so that timestamps are preserved


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.