[Bug 233213] Review Request: enblend - Image Blending with Multiresolution Splines

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: enblend - Image Blending with Multiresolution Splines


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233213


jspaleta at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From jspaleta at gmail.com  2007-03-25 01:36 EST -------
Summary: Approved 
Minor Issue: please fix redundant buildrequires when uploading to cvs before
your first build. 


Full review:
+ named according to guidelines
+ specfile named according to guidelines
+ license tag is GPL and is the most appropriate tag for the codebase. 
This does include some files under the MIT license as well, which is clarified
in the files included in the docs section. 
+ license files from source included in docs section
+ spec in legable english-ese 
+ sources match upstream 
f80a12ff91a6122c5ea0d102443929da  enblend-3.0.tar.gz
+ clean section looks good
+ consistent use of macros
+ contains permissible code.. no content at all
+ no need for a docs subpackage
+ no need for a -devel subpackage
+ no static libs, explictly disabled in the configure section
+ no pkgconfig files
+ no libtool archives
+ no desktop file.. not a gui app
+ no duplicate package ownership of installed files
+ no locales
+ no shared libs
+ all directories correctly owned.. in fact only the docs directory tree is created
+ no dupes in the files section
+ file permissions look okay
+ builds under mock on x86
+ uses RPM_OPT_FLAGS according to the visual inspection of build log
+ rpmlint clean for mock built packages
rpmlint enblend-3.0-2.fc7.i386.rpm
clean
rpmlint enblend-debuginfo-3.0-2.fc7.i386.rpm
clean
rpmlint enblend-3.0-2.fc7.src.rpm 
clean

- redundant buildrequires
mesa-libGL-devel and mesa-libGLU-devel are redundant 
both are required by freeglut-devel
n/a not designed to be relocated

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.