[Bug 234121] Review Request: PyOpenGL - Python bindings for OpenGL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyOpenGL - Python bindings for OpenGL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234121





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-29 04:15 EST -------
Well, for 3.0.0-0.1.a6:

* Executable permission vs shebang
---------------------------------------------------
chmod +x $RPM_BUILD_ROOT%{python_sitelib}/OpenGL/Tk/__init__.py \
  $RPM_BUILD_ROOT%{python_sitelib}/OpenGL/tests/test_glgetfloat_leak.py \
  $RPM_BUILD_ROOT%{python_sitelib}/OpenGL/tests/tests.py \
  $RPM_BUILD_ROOT%{python_sitelib}/OpenGL/tests/test_glutinit_0args.py \
  $RPM_BUILD_ROOT%{python_sitelib}/OpenGL/tests/test_glut_function_predef.py
---------------------------------------------------
  - Well, please make it sure:
    * If these scripts are expected to be called from other python
      scripts and are not expected to be called "directly" by user
      (well, "directly" used herein may be ambiguous), then
      having shebang is wrong and these files should _not_ have
      executable permission.
    * If opposite, i.e. these scripts are meant to be called directly
      by user, then these scripts should have executable permission.

    Usually the case is former.

* Python related dependency
  - Well, would you explain why the Requires for this package is
    enough by the following?
---------------------------------------------------
Requires:       python-numeric python-setuptools
---------------------------------------------------

    I usually check python related dependency by following. For this
    package, it returns many dependency, such as
    wxPython tkinter python-imaging pygame ... 

---------------------------------------------------
$ grep 'import ' `rpm -ql PyOpenGL | grep py$` | sed -e 's|^.*:||' | sed -e
's|^[ \t][ \t]*||' | sort | uniq
---------------------------------------------------


----------------------------------------------------
  Again, I would appreciate it if you would review
  either of my review request (from bug 233423 to bug 233426), thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.