[Bug 226387] Merge Review: samba

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: samba


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226387


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium




------- Additional Comments From dmitry at butskoy.name  2007-03-29 11:46 EST -------
Remarks and nitpicks
(against the current rawhide's 3.0.24-8):

- Whether the first line's "auth" macro is actually useful? Since "pam" includes
/etc/pam.d/system-auth (since at least FC1 time), just a requirement of "pam"
should be enough.
- The Summary tag values should not end in a period.
- Either drop "Epoch: 0" (seems unneeded?) or use it for changelog entries too
(i.e. "0:3.0.24-8")
- rpmlint prefers short "GPL" form for "License" field.
- Source0 should use new url (us4.samba.org), previous one is nonexistent now.
- "BuildRoot" must contain at least %{name}-%{version}-%{release}
- "BuildRequires" can be minimized. "libtool" already requires "autoconf", 
"openssl-devel" already requires "krb5-devel", and "cups-devel" already requires
"gnutls-devel". "fileutils" is obsoleted by "coreutils", which is in "BR
exception list" (since included in minimal build environment). 
- Either "samba-swat" must require "samba-doc", or move "docs/htmldocs" to
"samba-swat" sub-package (else swat will contain broken links to help/docs etc.)
- I don't know a package who removes its /var/log stuff on uninstall... :| . And
please, do not remove my /var/lib/samba/netlogon stuff too (<sarcasm>).
- use init scripts throw /sbin/service only (add Requires(post): /sbin/service etc.)
- ":" seems to be more robast/ancient rather than "true" (/bin/true) :)
- "libsmbslient" subpackage must do "/sbin/ldconfig" too.
- Explicit requirements of "pam" and "initscripts" seems to be unneeded (don't
sure about "logrotate")
- "libsmbslient-devel" looks like "one file package". Maybe merge it with
"libsmbclient", and add "Provides: libsmbclient-devel" for "libsmbclient" ?
- Since static libs considered deprecated now, either drop
"libsmbslient-devel-static", or write some words/links about necessity of static
libs (write as a comment into .spec file).
- Get rid of "macros in %changelog" (reported by rpmlint).
- Non-UTF8 symbols in %changelog (at 28 Aug 2002 and perhaps further to EOF).
- Init scripts must not be marked as %config files.
- Explicit "/etc" should be replaced to "%{_sysconfdir}".

Anyway, run "rpmlint -v package_file" for both src and binary rpms, and consider
the output (certainly some rpmlint points can be ignored).





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.