[Bug 225923] Merge Review: jakarta-commons-collections

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: jakarta-commons-collections


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225923


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium




------- Additional Comments From mwringe at redhat.com  2007-03-29 16:47 EST -------
(In reply to comment #2)
> X correct buildroot
>  - should be:
>    %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Fixed

> X specfile written in American English
> - the Summary for the tomcat5 subpackage says "Collection dependency ...." and
> description says "Collections dependency ....", (note the collections vs.
> collection) maybe it should be consistent with the other subpackages, and use
> "%{summary}." for the description.
Fixed

> X make a -doc sub-package if necessary
>  - just a question: is there any manual subpackage when not built with with_maven?
The manual needs maven1 to build, maven1 is not in Fedora so we can not build
the manual using the generated ant tasks. Since maven2 is now in Fedora, when
the project updates to maven2 we can then generate the manual.

>  
> X run rpmlint on the binary RPMs
> [pcheung at to-fcjpp1 review]$ rpmlint
>
/var/lib/mock/fedora-development-x86_64-core-pcheung/result/jakarta-commons-collections-*rpm
> W: jakarta-commons-collections non-standard-group Development/Libraries/Java
> W: jakarta-commons-collections non-standard-group Development/Libraries/Java
> E: jakarta-commons-collections-debuginfo description-line-too-long This package

The debuginfo rpm is completetly autogenerated, I can't alter the description line.

> provides debug information for package jakarta-commons-collections.
> W: jakarta-commons-collections-javadoc non-standard-group
Development/Documentation
> W: jakarta-commons-collections-testframework non-standard-group
Development/Testing
> W: jakarta-commons-collections-testframework no-documentation
> W: jakarta-commons-collections-testframework filename-too-long-for-joliet
> jakarta-commons-collections-testframework-3.1-9jpp.1.fc7.x86_64.rpm
> W: jakarta-commons-collections-testframework-javadoc non-standard-group
> Development/Documentation
> W: jakarta-commons-collections-testframework-javadoc
> filename-too-long-for-joliet
> jakarta-commons-collections-testframework-javadoc-3.1-9jpp.1.fc7.x86_64.rpm
> W: jakarta-commons-collections-tomcat5 non-standard-group
Development/Libraries/Java
>  
> Is it possible to fix the error?  What about the filename-too-long-for-joliet
> warnings? (Or are those (description and filename) all auto-generated?)

I am not so sure about the joliet warnings, this is because the filename is too
long for the rpm. Since this is only a warning, and this package has been in
Fedora a couple of release with this issue, I think it should be safe to ignore.
The only way to get rid of this message is to rename the packages.

Updated package here:
https://mwringe.108.redhat.com/files/documents/175/324/jakarta-commons-collections-3.1-9jpp.1.src.rpm




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.