[Bug 234571] Review Request: perl-Bio-ASN1-EntrezGene - Regular expression-based Perl Parser for NCBI Entrez Gene

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Bio-ASN1-EntrezGene - Regular expression-based Perl Parser for NCBI Entrez Gene
Alias: Bio-ASN1-Entrez

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234571


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cweyl at alumni.drew.edu




------- Additional Comments From cweyl at alumni.drew.edu  2007-03-31 11:51 EST -------
Before I launch into a full review,  a couple comments.

A stylistic comment -- if you use

    %setup -q -n Bio-ASN1-EntrezGene-%{version}

vs  %setup -q -n Bio-ASN1-EntrezGene-1.09

in %prep, you won't have to manually change the version in two places whenever
a new version is released.  (Not that this seems to happen frequently, but...)

There appears to be an examples directory, why not include it? :)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.