[Bug 234454] Review Request: perl-PostScript - PostScript Perl module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-PostScript - PostScript Perl module
Alias: perl-PostScript

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234454





------- Additional Comments From cweyl at alumni.drew.edu  2007-03-31 12:06 EST -------
Looks good :)

+ source files match upstream:
2a91cc23f2d8958e063f7ff09163faa0  PostScript-0.06.tar.gz
2a91cc23f2d8958e063f7ff09163faa0  ../PostScript-0.06.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.  License text not included upstream. 
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
O no debuginfo package -- noarch
+ rpmlint is silent.
+ final provides and requires are sane:
** perl-PostScript-0.06-1.fc6.noarch.rpm
== rpmlint
== provides
perl(PostScript::Document) = 0.06
perl(PostScript::Elements)  
perl(PostScript::Metrics) = 0.06
perl(PostScript::TextBlock) = 0.06
perl-PostScript = 0.06-1.fc6
== requires
perl(:MODULE_COMPAT_5.8.8)  
perl(PostScript::Metrics)  
perl(PostScript::TextBlock)  
perl(strict)  
perl(vars)  
O %check is present -- no tests defined, however
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.