[Bug 238270] Review Request: widelands - realtime-strategy game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: widelands - realtime-strategy game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238270


nphilipp at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nphilipp at redhat.com




------- Additional Comments From nphilipp at redhat.com  2007-05-01 04:49 EST -------
I just noticed your widelands submission and since I've packaged an old version
of it privately, I have some comments about your spec file to add (I'll attach a
diff between your original and what my comments would implement for good measure):

1) Shorten the summary a bit, I suggest something like "Open source
realtime-strategy game"

2) Consider using just

Release:        0.build%{buildnum}.%{rel}%{?dist}

to avoid redundancy in the release tag and have the dist/version tag.

3) I'd add the version of the package for which my patches are built in the
filename, i.e. widelands-build10-workfix.patch and
widelands-build10-flagfix.patch. This way changes in the patches are more
obvious (because the version gets bumped then).

4) Add some blank lines between spec file sections and changelog entries, this
improves readability.

5) Capitalize the GenericName of the desktop file ("Realtime Strategy Game")

6) No need to use --delete-original when installing the spec file as the
buildroot will be emptied at the beginning of %install

I'll be on vacation from next week on, so unfortunately I can't volunteer for
the review now.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.