[Bug 237380] Review Request: ruby-gettext-package - Localization Library and Tools for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  ruby-gettext-package - Localization Library and Tools for Ruby
Alias: ruby-gettext-package

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237380





------- Additional Comments From jasperhartline at adelphia.net  2007-05-01 10:58 EST -------
Chitlesh Goorah has asked me to do an informal review of this package.
Upon installing all BuildRequires, the package builds cleanly in Fedora Core 6
with a single warning from rpmlint:
W: ruby-gettext-package invalid-license Ruby License/LGPL

This should be LGPL rather than Ruby License/LGPL

In examining your SPEC file, I see you can collapse some Requires and
BuildRequires using this format:
BuildRequires:  irb, ruby-devel, ruby(abi = %{rubyabi}
Requires:       irb, ruby(abi) = %{rubyabi}

rather than:
BuildRequires:  irb
BuildRequires:  ruby-devel
BuildRequires:  ruby(abi) = %{rubyabi}
Requires:       ruby(abi) = %{rubyabi}
Requires:       irb

I also notice in the SPEC, the %files section has:
%files -f %{name}.lang
You might want to look into using:
%{find_lang} 
instead.

See: rpmbuild --showrc | grep find_lang



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.