[Bug 235636] Review Request: pipepanic - A pipe connecting game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pipepanic - A pipe connecting game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235636


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |j.w.r.degoede at hhs.nl
               Flag|                            |fedora-review?




------- Additional Comments From j.w.r.degoede at hhs.nl  2007-05-01 16:31 EST -------
MUST:
=====
* rpmlint output is clean
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel x86_64
* BR: ok
* No locales
* No shared libraries, ldconfig not needed
* Not relocatable
0 Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code and permissable content
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed
* .desktop file as required and properly installed

MUST FIX
========
* /usr/share/pipepanic is not owned, change:
  %{_datadir}/%{name}/* under files to just %{_datadir}/%{name}

Should FIX
==========
* Drop " that is playable on Linux PCs and the Sharp Zaurus." from %description
  ofcourse it runs on linux, its a Fedora package, and that it also runs
  on the Zaurus is of 0 interest.
* Set a window title, currently the window is untitled. I'll attach a patch for 
  this. Notice that this patch also needs an icon file in bmp format installed
  as /usr/share/pipepanic/icon.bmp

  This file can be generated by the following obscure ImageMagick command,
  and yes the using of convert twice and the | is necessary:
convert PipepanicIcon32.png bmp3:- | convert - -fill '#FF00FF' -opaque black
-colors 256 -compress none bmp3:icon.bmp


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.