[Bug 235191] Review Request: postr - Flickr uploader

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: postr - Flickr uploader


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235191





------- Additional Comments From jspaleta at gmail.com  2007-05-03 04:17 EST -------
The GOOD
+ naming is good
+ specfile name matches base package name 
+ Licensed as GPL and includes COPYING file accordingly
+ specfile written in english-ese and is legible
+ included source md5sum checks with upstream source as listed in SOURCE0 url
a66f58dbdc5c1a1befd3fa9cee629b52  postr-0.5.tar.gz
+ builds on x86 fedora-development in mock
+ no locales
+ not relocatable
+ permissions seem to be okay
+ clean section is okay
+ consistent use of macros
+ permissible code and content
+ items in doc are not runtime necessary
+ gui, desktop file installation looks good
+ does not obviously own files from another package 
+ install section looks good
+ No .la files
+ No devel subpackage
+ Need need to for shared libraries sciptlets
+ icon cache scriplet lets look good.

rpmlint binary clean:
postr-0.5-2.fc7.noarch.rpm
E: postr only-non-binary-in-usr-lib
  this is bogus, an typical of python files due to module tree location.

rpmlint srpm only minor warning:
postr-0.5-2.fc7.src.rpm
W: postr mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 46)
  Nuke the tabs in the whitespace of the desktop file install command and this
goes away.

Application appears to function for me as anticipated. Photos were uploaded,
there was much rejoicing.

The BAD
- SOURCE1 instructions do not produce tarball with matching md5sum. Not sure
what's going on here. I can confirm that repeated tar czf  gives different
md5sums. But tar cf  gives me something reproducible.
So if i decompress the included tarball I still get a md5sum on postr-icons.tar
compared to the one i create with bzr and tar cf data setup.py. Double check to
see if you can get consistent comparisons against the tar file instead of the
tar.gz.

- base package must own all directories it creates and directory ownership of
parent directories is accounted for in package deps

Problem: /usr/share/icons/hicolor/*/apps/ not owned by a required dep.
Solution: adds Requires: hicolor-icon-theme   

Problem: /usr/lib/nautilus/extensions-1.0/python is not owned by any package.
Suggested Solution: make the nautilus-python package create and own this
directory. Fix is outside the scope of this review. But if you can commit a fix
to the python-nautilus package with this fix , it will clear up the issue here.

-Requires
Do you really want to pull in python-twisted or do you want to pull in only a
subset of the twisted packages? Looking over the python code in postr it looks
like you technically only need to require python-twisted-core and
python-twisted-web, instead of the metapackage python-twisted.


So overall, pretty close to being approvable... that gzip behavior seems odd to me.

-jef

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.