[Bug 238824] Review Request: schismtracker - sound module composer/player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: schismtracker - sound module composer/player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238824


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(ville.skytta at iki.f|
                   |i)                          |




------- Additional Comments From ville.skytta at iki.fi  2007-05-03 17:08 EST -------
(In reply to comment #2)

Please bump the release tag always when making changes to packages, even while
they're in review.  Makes it a less PITA to track progress and compare changes.

Regarding the release tag, the common form for pre-release packages is eg.
0.X.rc1, not 0.Xrc1 as in this package.  Not a big deal though, but I'd suggest
changing it.

> > - MIME type associations missing from .desktop file, suggested:
> >     MimeType=audio/x-mod;audio/x-s3m;audio/x-stm;audio/x-it;audio/x-xm;
> Ok, I also added the audio/x-669-mod and audio/x-mtm.

This seems to have slipped the SRPM build, there's no MimeType included in the
*.desktop in it.

> > - Menu entry icon missing - install a bunch of different sizes from icons/
> > subdirs to /usr/share/icons/hicolor/*?
> Done.

Ok, but %{_datadir}/icons/* results in ownership of a lot of dirs commonly owned
by other packages.  Does any of this package's dependencies bring in
hicolor-icon-theme?  If yes, the dir/file ownership should be changed to
something like %{_datadir}/icons/hicolor/*x*/apps/%{name}.png

"Icon=%{name}" or something similar should be added to the desktop file.

gtk-update-icon-cache missing, see
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda

> > - What are the libXau-devel and libXdmcp-devel build dependencies used for?
> ldd says schismtracker is dependent on them, so I listed them explicitely.

My ldd on FC6 x86_64 doesn't, and I don't see anything in the sources that would
 use them.  Which distro version and arch did you use for building your package
that shows those deps?  Perhaps there's something causing unneeded lib
dependency bloat there.

> > - Missing build dependencies: libXt-devel, libXxf86misc-devel, libXv-devel
> These seem to be brought by SDL-devel.

Not on FC6 x86_64.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.