[Bug 235804] Review Request: ocaml-SDL - OCaml bindings for SDL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-SDL - OCaml bindings for SDL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235804





------- Additional Comments From dev at nigelj.com  2007-05-03 17:09 EST -------
(In reply to comment #10)
> MUST FIX
> ========
> * Change Source0 from:
> http://optusnet.dl.sourceforge.net/sourceforge/ocamlsdl/ocamlsdl-0.7.2.tar.gz
>   to the generic sf download url, and use %{version}:
> http://downloads.sourceforge.net/ocamlsdl/ocamlsdl-%{version}.tar.gz
Done
> * main package must require ocaml for /usr/lib/ocaml/stublibs dir ownership
Done
> * remove the unnecessary ldconfig %post(un) scripts, this are not normally
>   libs and since they are not installed in a path searched by ldconfig, calling
>   ldconfig is useless.
True, good point, done
> 
> Should Fix
> ==========
> * Stop the obfuscated double %setup usage, instead of the 2 lines you can just
> write: "%setup -q -n ocamlsdl-%{version} -a 1"
I was fighting that one for a ittle while, thanks
> 
> * No need to write:
>   %dir %{_libdir}/ocaml/sdl
> 
>   %{_libdir}/ocaml/sdl/*.*a
>   %{_libdir}/ocaml/sdl/*.cmi
>   %{_libdir}/ocaml/sdl/*.cmx
>   Instead you can just write:
>   %{_libdir}/ocaml/sdl
>   If there were files there which you wouldn't include with the wildcards,
>   then rpmbuild would refuse to build the rpm as there would be files in
>   $RPM_BUILD_ROOT, which aren't listed under any %files.
Which is handy, because the build won't complete if something changes for the
worst (i.e. more unneeded output, but I see your point)
> 
> * also please always make all your %files entries like this:
>   %files
>   %defattr(....)
>   %doc ...
>   <other files and dirs>
> 
Done

--

Spec URL: http://dev.nigelj.com/SRPMS/ocaml-SDL.spec
SRPM URL: http://dev.nigelj.com/SRPMS/ocaml-SDL-0.7.2-5.src.rpm

In about 10 mins

* Fri May 04 2007 Nigel Jones <dev at nigelj.com> 0.7.2-5
- Minor fixups per review

--

I've also added the ocaml dependency as suggested on Bug #235805

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.