[Bug 237813] Review Request: taxipilot - Game where you pilot a taxi in space

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: taxipilot - Game where you pilot a taxi in space


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237813





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-05-04 00:38 EST -------
(In reply to comment #3)
> 1. rpmlint returns
> [paczka at localhost ~]$ rpmlint /var/lib/mock/fedora-development-i386-core/result
> W: taxipilot dangling-symlink /usr/share/doc/HTML/en/taxipilot/common
> /usr/share/doc/HTML/en/common
> W: taxipilot symlink-should-be-relative /usr/share/doc/HTML/en/taxipilot/common
> /usr/share/doc/HTML/en/common
> E: taxipilot zero-length /usr/share/apps/taxipilot/game_data/game_data_tag
> 

As already expained in comments above, the dangling symlink warning is normal
for KDE packages, the directory the link points to is provided by kdelibs

> 2. "Data files (maps, pixmaps, sounds) go in  %{_datadir}/%{name} , not
> %{_datadir}/games/%{name} . According to the FHS, the use of /usr/share/games is
> optional, and we recommend not using it for consistency so that games are
> packaged like all other applications."
> In the rpm, datafiles are in /usr/share/apps. Please check it.
> 

Again, this is a KDE app, all kde apps have their data under
%{_datadir}/apps/%{name}

> 3. "Installed .desktop files MUST follow the [desktop-entry-spec], paying
> particular attention to validating correct usage of Name, GenericName,
> [Categories], [StartupNotify] entries."
> In .desktop is not defined GenericName and the shortcut is after installation in
> Games without any category, check it.
> 

GenericName use is optional and doesn't make any sense for Games. The game ends
up in the Games menu and not in a submenu, because non of the default KDE Games
menu submenus make sense for it. If you install the games-menus package you will
get more submenus under KDE and submenus under Games and then it will go under
the "Action Games" submenu (best match)

> 4. "- MUST: Packages must NOT contain any .la libtool archives, these should be
> removed in the spec."
> There is %{_libdir}/libEXT_wavpo.la
> 

<sigh> There is a comment about this in the spec file:
# .la file is included deliberately -> kde

KDE needs .la files in certain cases.

> 5. Add NEWS to %doc, please.
> 

NEWS doesn't have any (relevant) content.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.