[Bug 235804] Review Request: ocaml-SDL - OCaml bindings for SDL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-SDL - OCaml bindings for SDL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235804


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |
              nThis|                            |
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From j.w.r.degoede at hhs.nl  2007-05-04 03:00 EST -------
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > MUST FIX
> > > ========
> > > * remove the unnecessary ldconfig %post(un) scripts, this are not normally
> > >   libs and since they are not installed in a path searched by ldconfig,
calling
> > >   ldconfig is useless.
> > True, good point, done
> While I said done, I omitted it from the srpm, I've removed it from my local
> copy, however.  Would you like another upload?

No that won't be necessary, I'll trust you to remove this before import or building.

All Must fix items fixed: approved

One should still remaining though, the new recommended (per guideline)
sourceforge download url now a days is:
http://downloads.sourceforge.net/ocamlsdl/ocamlsdl-%{version}.tar.gz
Notice the downloadSSSSSSS and the removal of /sourceforge/
You might want to change this/



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.