[Bug 223586] Review Request: strigi - A desktop search program for KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: strigi - A desktop search program for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223586





------- Additional Comments From dakingun at gmail.com  2007-05-04 13:39 EST -------
(In reply to comment #15)
> informal review:
> 
> 1. SHOULD remove 
> BR: dbus-qt-devel
> (that's the qt3 dbus bindings, qt4 has integrated DBus binding support)
>
strigi is also useful with qt3, i believe.
 
> 2. SHOULD add to -devel 
> Requires: pkgconfig

Will do.

> 
> 3. cmake in fedora has been updated to include convenience rpm macros, so you
> can simplify it's usage, see
> http://fedoraproject.org/wiki/PackagingDrafts/cmake
The cmake rpm macro doesn't play nicely with strigi, the build fails somewhere
along the way with it. I think it particularly has to do with the macro
definning -DCMAKE-SHARED-LIBS=ON. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.