[Bug 222575] Review Request: php-pear-HTML-QuickForm-ElementGrid - Meta-element which holds any other element in a grid

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-HTML-QuickForm-ElementGrid - Meta-element which holds any other element in a grid
Alias: pear-ElementGrid

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222575


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium

tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
OtherBugsDependingO|163776                      |
              nThis|                            |
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-05-05 23:59 EST -------
Let me go ahead and ack this, since Sebastien isn't sponsored yet.

Nothing from rpmlint; everything looks good.

* source files match upstream:
26a09d192dfcc27a250b940943b02e0d1d0c59d0329a5350c915d41164e901ba
HTML_QuickForm_ElementGrid-0.1.0.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
O latest version is 0.1.1.
  This came out way after you submitted the review; any reason for not
  packaging it instead?
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear(HTML_QuickForm_ElementGrid) = 0.1.0
   php-pear-HTML-QuickForm-ElementGrid = 0.1.0-1.fc7
  =
   /bin/sh
   /usr/bin/pear
   php-pear(HTML_QuickForm) >= 3.2.5
   php-pear(HTML_Table) >= 1.7.5
   php-pear(PEAR)

* %check is not present; not test suite upstream.
* owns the directories it creates.
  (/usr/share/pear/HTML/QuickForm is owned by a dependency)
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.