[Bug 225447] Review Request: php-magpierss - MagpieRSS is an RSS parser written in PHP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-magpierss -  MagpieRSS is an RSS parser written in PHP


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225447


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-05-06 02:16 EST -------
Well, there's not much to this package.  rpmlint is completely silent.

A couple of minor issues:

The indentation in %description looks a little odd.
There's no need for the leading slash here:
  /%{_datadir}/php/magpierss/

I don't think these are blockers.

* source files match upstream:
   7cf9698ade1067d19c4c551529928b70bdc270fd7c450c4eba883a17ac4614c3
   magpierss-0.72.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (none needed)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-magpierss = 0.72-2.fc7
  =
   php
* %check is not present; no test suite upstream.
* owns the directories it creates.
   /usr/share/php comes from php-common, which is a dependency of php.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.