[Bug 239155] Review Request: perl-Class-Gomor - Another class and object builder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Class-Gomor -  Another class and object builder
Alias: perl-Class-Gomor

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239155





------- Additional Comments From cweyl at alumni.drew.edu  2007-05-06 14:07 EST -------
Missing BR's on perl(Test::More), perl(ExtUtils::MakeMaker), perl(Test::Pod),
perl(Test::Pod::Coverage) [though the last one isn't a blocker].

There's an examples/ directory, why not include it?  For the purposes of this
review, I've added it to %doc.

Add examples/ to %doc and the missing BR's, and I'll approve :)

+source files match upstream:
 53f611cd26439fa35ce1e84d700d777a  Class-Gomor-1.01.tar.gz
 53f611cd26439fa35ce1e84d700d777a  ../Class-Gomor-1.01.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text included in package.
+ latest version is being packaged.
X BuildRequires are proper.
+ compiler flags are appropriate. (noarch)
+ %clean is present.
+ package installs properly
+ rpmlint is silent.
+ final provides and requires are sane:
 ** perl-Class-Gomor-1.01-1.fc6.noarch.rpm
 == rpmlint
 == provides
 perl(Class::Gomor) = 1.01
 perl(Class::Gomor::Array) = 1.01
 perl(Class::Gomor::Hash) = 1.01
 perl-Class-Gomor = 1.01-0.1.fc6
 == requires
 perl(:MODULE_COMPAT_5.8.8)  
 perl(Carp)  
 perl(Class::Gomor)  
 perl(Data::Dumper)  
 perl(Exporter)  
 perl(strict)  
 perl(warnings)
+ %check is present and all tests pass:
 All tests successful.
 Files=12, Tests=16,  1 wallclock secs ( 0.60 cusr +  0.18 csys =  0.78 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.