[Bug 239193] Review Request: perl-Module-ExtractUse - Find out what modules are used
bugzilla at redhat.com
bugzilla at redhat.com
Sun May 6 20:50:50 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Module-ExtractUse - Find out what modules are used
Alias: Module-ExtractUse
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239193
cweyl at alumni.drew.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
Alias| |Module-ExtractUse
------- Additional Comments From cweyl at alumni.drew.edu 2007-05-06 16:50 EST -------
(In reply to comment #1)
> - Summary could be improved, how about appending " in Perl code" to it?
Not a problem.
> - Rationale for including the t/ dir in docs? Doesn't look useful to me,
> neither does TODO.
This was actually discussed a little over at bug 235790. Basically, it boils
down to:
* tests can make good documentation (sometimes better than the actual docs)
* people might actually want to test the package post-installation
* it doesn't hurt anything :)
> - The included cpan.pl example doesn't work (non-blocker, but nice if fixed):
> $ perl cpan.pl SGML-Parser-OpenSP
> Required option 'allow' is not provided for CPANPLUS::Backend::search by
> ANON at cpan.pl line 12
I'll take a look at this -- so long as I don't have to introduce any new deps it
would be nice to have it working :)
> - perl-Pod-Strip's dependencies would be nice to have fixed before importing
> this, see bug 239241 (no changes needed in this package). Otherwise:
> $ perl -MModule::ExtractUse -e ''
> Base class package "Pod::Simple" is empty.
> (Perhaps you need to 'use' the module which defines that package first.)
> at /usr/lib/perl5/vendor_perl/5.8.8/Pod/Strip.pm line 6
> BEGIN failed--compilation aborted at
> /usr/lib/perl5/vendor_perl/5.8.8/Pod/Strip.pm line 6.
> Compilation failed in require at
> /usr/lib/perl5/vendor_perl/5.8.8/Module/ExtractUse.pm line 6.
> BEGIN failed--compilation aborted at
> /usr/lib/perl5/vendor_perl/5.8.8/Module/ExtractUse.pm line 6.
> Compilation failed in require.
> BEGIN failed--compilation aborted.
Ugh, messy. I suppose I could add a requires on perl(Pod::Simple) until it's
fixed in perl-Pod-Strip; for the purposes of review at least.
It's a beautiful day out here in San Francisco, and I'm being informed that I
need to get outside :) I'll post an updated srpm later on...
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list