[Bug 238994] Review Request: memcached - High Performance, Distributed Memory Object Cache

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: memcached - High Performance, Distributed Memory Object Cache


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238994





------- Additional Comments From bjohnson at symetrix.com  2007-05-08 04:26 EST -------
Created an attachment (id=154318)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=154318&action=view)
fixes 'unexpected success' in maxconnect.t

I'm not a sponsor either, but here are some more comments:

1) Package should Require initscripts

2) I suggest you turn on the make test portion (we like automated testing).  To
do this, you need to BuildRequire perl(Test::More).  Then to make things sane
in the test, you'll want to:

# delete test that weren't written, and daemonize doesn't work in koji
rm -f
t/{binary-get,daemonize,lru,managed-buckets,multiversioning,slab-reassign,unixsocket}.t


then apply the attached patch to fix one test that wasn't completed.

(By the way, daemonize can be fixed by using a random port for testing)

I also see that memcache-debug gets installed?	Is that useful?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.