[Bug 237330] Review Request: perl-Crypt-OpenSSL-AES -- Perl OpenSSL bindings for AES support -- SPONSOR NEEDED

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  perl-Crypt-OpenSSL-AES -- Perl OpenSSL bindings for AES support -- SPONSOR NEEDED


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237330





------- Additional Comments From tibbs at math.uh.edu  2007-05-09 18:50 EST -------
Sorry, I saw the cascading build failures and misinterpreted them.

Indeed, perl_vendorlib would have pulled in all of the files, but would also
have had you owning the perl_vendorarch directory, which would have been
problematic.

Things look better now.

I note that Source0: seems wrong.  You have 
http://search.cpan.org/authors/id/I/IR/IROBERTS/Crypt-OpenSSL-AES-%{version}.tar.gz
but that only results in an error.  CPAN indicates it should be 
http://search.cpan.org/CPAN/authors/id/T/TT/TTAR/Crypt-OpenSSL-AES-%{version}.tar.gz

I've used the latter so that I can fetch the upstream sources.

You'll need to add BuildRequires: perl(ExtUtils::MakeMaker), perl(Test::More) to
cope with the perl-devel split.  (See the end of 
http://fedoraproject.org/wiki/Packaging/Perl.  Actually, Test::More is still in
the base Perl package but I'm not sure if the plans are to keep it there.)  


* source files match upstream:
   83c1c438ef394fb9c9925805a07dce9865794e79df8ca19686c8548cd99fca97  
   Crypt-OpenSSL-AES-0.01.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
X BuildRequires missing
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   AES.so()(64bit)
   perl(Crypt::OpenSSL::AES) = 0.01
   perl-Crypt-OpenSSL-AES = 0.01-2.fc7
  =
   libcrypto.so.6()(64bit)
   perl >= 0:5.008005
   perl(:MODULE_COMPAT_5.8.8)
   perl(Exporter)
   perl(XSLoader)
   perl(strict)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=4,  0 wallclock secs ( 0.02 cusr +  0.01 csys =  0.03 CPU)
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la droppings.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.