[Bug 236366] Review Request: clutter-gtk - basic GTK clutter widget

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clutter-gtk - basic GTK clutter widget


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236366





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-05-10 13:14 EST -------
* Should/Must fix
! Suggestion or something else
? Question

For 0.1.0-1:

! Redundant dependencies (NOT A BLOCKER)
  - gtk2-devel is required by clutter-devel (as clutter-devel 
    requires gdk-pixbuf-2.0.pc). So "(Build)Requires: gtk2-devel"
    can be removed.

    However for this package I don't force you to remove "gtk2-devel"
    because clutter-gtk.pc explicitly requires gtk+-2.0.pc.

* File/directory ownership issue
  - The following directories are already owned by other packages
    and should not be owned by these packages.
--------------------------------------------------------
/usr/include/clutter-0.2   owned by clutter-devel
--------------------------------------------------------

* Documentation
  - The following files should not be installed as documentation
--------------------------------------------------------
INSTALL - this file is needed for people who want to install this
          software by themselves and is not needed for rpm
          management.
--------------------------------------------------------

* Timestamps
  - This package installs some files which are not built or modified
    during rebuild (header file and documentation), and
    keeping timestamps on these files is highly recommended.
    For this package, please use the following:
--------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"
--------------------------------------------------------

? License (NOT A BLOCKER)
  - Well, actually COPYING file declares that this is licensed under
    GPL, however all sources are licensed under LGPL and
    license.html also says this is LGPL-licensed.
    Would you ask which license is correct? (either is okay so
    this is not a blocker)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.