[Bug 225575] Review Request: roundcubemail - Round Cube Webmail is a browser-based multilingual IMAP client
bugzilla at redhat.com
bugzilla at redhat.com
Sat May 12 06:21:00 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: roundcubemail - Round Cube Webmail is a browser-based multilingual IMAP client
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225575
------- Additional Comments From bjohnson at symetrix.com 2007-05-12 02:20 EST -------
Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format %{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: FC6 / i386
[x] Rpmlint output:
E: roundcubemail non-standard-gid /var/log/roundcubemail apache
E: roundcubemail non-standard-dir-perm /var/log/roundcubemail 0775
E: roundcubemail non-standard-gid /etc/roundcubemail/main.inc.php apache
E: roundcubemail non-readable /etc/roundcubemail/main.inc.php 0640
E: roundcubemail non-standard-gid /etc/roundcubemail/db.inc.php apache
E: roundcubemail non-readable /etc/roundcubemail/db.inc.php 0640
W: roundcubemail percent-in-%post
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL
Packager has properly generated a custom tarball removing code that
conflicts with GPL license.
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package :
ac64aea002c4951b1a3005fe966082bf roundcube_arabic-0.1-beta2.tar.gz
c1d4e21cd1280a3f5f06892ddcd5f1b9 roundcube_armenian-0.1-beta2.tar.gz
7817973ca9f280ee60980668401bf7f8 roundcube_brazilian-0.1-beta2.tar.gz
fc98428238cb77af3c8f336aadc4168d roundcube_catala-0.1-beta2.tar.gz
71490edf78375bd273f1326d77d3e449 roundcube_chinese-0.1-beta2.tar.gz
eb389dc044924b476a67cf7be2109714 roundcube_chinese-big5-0.1-beta2.tar.gz
7252bc28846db945500ea45071f08012 roundcube_czech-0.1-beta2.tar.gz
77202ea30056a63ff208cdade1eef279 roundcube_danish-0.1-beta2.tar.gz
0b94ca8e149a443ab42bbb96b9c149df roundcube_dutch-0.1-beta2.tar.gz
b23398f6df2767c192f7498b6197ed3a roundcube_estonian-0.1-beta2.tar.gz
62963ef840c6f9f104119870a7486e19 roundcube_hungarian-0.1-beta2.tar.gz
f5641dc92c9c76b7d3dd9da5656aae94 roundcube_italiano-0.1-beta2.tar.gz
323ae63d544f0febf72418d0b44967ff roundcube_japanese-0.1-beta2.tar.gz
ba62761bbee19a8d91a1796fa4bb297a roundcube_latvian-0.1-beta2.tar.gz
50d48afe8cfee6b5db4a20eeaafd1fbf roundcubemail-0.1beta2.2.tar.gz
e72c13a77dde332b07417e41fbdd6434 roundcube_norwegian-0.1-beta2.tar.gz
5455303054e3fcd70d38a9e2c01e9fa3 roundcube_polish-0.1-beta2.tar.gz
fe38f58dadeb05806320d7ddadabb000 roundcube_portuguese-0.1-beta2.tar.gz
f91874d95f46c830837335c5b33ef8b9 roundcube_romanian-0.1-beta2.tar.gz
2e071a52d3ffdb4707a062d740f85691 roundcube_serbian-0-1-beta2.tar.gz
6e021e49da6f64506b305bcd01c2e9c9 roundcube_slovak-0.1-beta2.tar.gz
f577b2cce8dd031f427b5f3f343649f3 roundcube_swedish-0.1-beta2.tar.gz
c28485169c7127b5f17584e6fe175280 roundcube_turkish-0.1-beta2.tar.gz
25289980efaf7c655028e4ce889764cd roundcube_vietnamese-0.1-beta2.tar.gz
MD5SUM upstream package:
ac64aea002c4951b1a3005fe966082bf roundcube_arabic-0.1-beta2.tar.gz
c1d4e21cd1280a3f5f06892ddcd5f1b9 roundcube_armenian-0.1-beta2.tar.gz
7817973ca9f280ee60980668401bf7f8 roundcube_brazilian-0.1-beta2.tar.gz
fc98428238cb77af3c8f336aadc4168d roundcube_catala-0.1-beta2.tar.gz
71490edf78375bd273f1326d77d3e449 roundcube_chinese-0.1-beta2.tar.gz
eb389dc044924b476a67cf7be2109714 roundcube_chinese-big5-0.1-beta2.tar.gz
7252bc28846db945500ea45071f08012 roundcube_czech-0.1-beta2.tar.gz
77202ea30056a63ff208cdade1eef279 roundcube_danish-0.1-beta2.tar.gz
0b94ca8e149a443ab42bbb96b9c149df roundcube_dutch-0.1-beta2.tar.gz
b23398f6df2767c192f7498b6197ed3a roundcube_estonian-0.1-beta2.tar.gz
62963ef840c6f9f104119870a7486e19 roundcube_hungarian-0.1-beta2.tar.gz
f5641dc92c9c76b7d3dd9da5656aae94 roundcube_italiano-0.1-beta2.tar.gz
323ae63d544f0febf72418d0b44967ff roundcube_japanese-0.1-beta2.tar.gz
ba62761bbee19a8d91a1796fa4bb297a roundcube_latvian-0.1-beta2.tar.gz
e72c13a77dde332b07417e41fbdd6434 roundcube_norwegian-0.1-beta2.tar.gz
5455303054e3fcd70d38a9e2c01e9fa3 roundcube_polish-0.1-beta2.tar.gz
fe38f58dadeb05806320d7ddadabb000 roundcube_portuguese-0.1-beta2.tar.gz
f91874d95f46c830837335c5b33ef8b9 roundcube_romanian-0.1-beta2.tar.gz
47f2fc3fc5e0b3325ca3c3a360011a03 roundcube_russian-0.1-beta2.tar.gz
2e071a52d3ffdb4707a062d740f85691 roundcube_serbian-0-1-beta2.tar.gz
6e021e49da6f64506b305bcd01c2e9c9 roundcube_slovak-0.1-beta2.tar.gz
f577b2cce8dd031f427b5f3f343649f3 roundcube_swedish-0.1-beta2.tar.gz
c28485169c7127b5f17584e6fe175280 roundcube_turkish-0.1-beta2.tar.gz
25289980efaf7c655028e4ce889764cd roundcube_vietnamese-0.1-beta2.tar.gz
roundcube source tarball is a custom tarball
[x] Package is not known to require ExcludeArch, OR:
Arches excluded:
Why:
[x] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: FC6 / i386
[-] Package should compile and build into binary rpms on all supported
architectures.
Tested on:
[x] Package functions as described.
[x] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files are correct.
[-] File based requires are sane.
=== Issues ===
1. Please use wget -N or equivalent to download source files and preserve
timestamps.
2. Missing the russian langpack.
3. I see that there is also a log directory listed in main.inc.php so the same
sed to fix the logs/ dir should be applied there.
4. I don't think your logrotate is right. The conf file is to rotate a file
called "logfile", but at least on my system, the only logfile created is
"errors". Please check.
5. This line: %dir %config(noreplace) %{_sysconfdir}/logrotate.d/roundcubemail
should not have a %dir because it is a file.
=== Final Notes ===
1. Once the selinux policy is updated for bug #239436, you'll want to add a
Conflicts: selinux-policy-targeted < version_it_was_fixed_in. You can do this
post import.
Get those minor issues listed fixed and I'll approve your package.
Please note I'll be traveling for the next ten days or so. Expect my responses
to be very slow.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list