[Bug 239884] Review Request: liberation-fonts - Fonts to replace commonly used Microsoft Windows Fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: liberation-fonts -  Fonts to replace commonly used Microsoft Windows Fonts


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239884


nicolas.mailhot at laposte.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Additional Comments From nicolas.mailhot at laposte.net  2007-05-12 05:19 EST -------
Formal review:

☑ MUST: rpmlint must be run on every package. OK

$ rpmlint /srv/rpm/liberation-fonts-0.1-5.fc7.nim.*
W: liberation-fonts incoherent-version-in-changelog 0.1-5 0.1-5.fc7.nim

- Just a dist/changelog clash, ignored

☑ MUST: The package must be named according to the Package Naming Guidelines. OK
☑ MUST: The spec file name must match the base package %{name}… OK
☑ MUST: The package must meet the Packaging Guidelines. OK
☑ MUST: The package must be licensed with an open-source compatible license… OK

☒ MUST: The License field in the package spec file must match the actual
license. NOK

- As the license is not vanilla GPL v2, GPL field is misleading

☒ MUST: If … text of the license(s) for the package must be included in %doc. NOK

1. Don't do that:
install -m 0644 License.txt %{buildroot}%{_datadir}/fonts/liberation
2. The license text does not seem UTF-8 encoded

☑ MUST: The spec file must be written in American English. OK
☑ MUST: The spec file for the package MUST be legible. OK
☒ MUST: The sources used to build the package must match the upstream source… NOK

1. Please add a source URL to the package
2. Make sure the archive name and content match the signed archive on the RH page
3. For fonts tar.bz2 is probably a better idea than tar.gz

☑ MUST: The package must successfully compile and build into binary rpms… OK
☑ MUST: If the package does not successfully compile, build or work on an… N/A
☑ MUST: All build dependencies must be listed in BuildRequires… OK
☑ MUST: The spec file MUST handle locales properly… N/A
☑ MUST: Every binary RPM package which stores shared library files… N/A
☑ MUST: If the package is designed to be relocatable… N/A
☑ A package must own all directories that it creates… OK
☑ MUST: A package must not contain any duplicate files in the %files listing. OK
☑ MUST: Permissions on files must be set properly… OK

- though a %defattr(0644,root,root,0755) would be nicer

☑ MUST: Each package must have a %clean section… OK

- please move the clean section to its usual place after %install

☑ MUST: Each package must consistently use macros… OK

- please define and use fontdir and fontconfdir as in other font packages
(dejavu-lgc…)

☑ MUST: The package must contain code, or permissable content… OK
☑ MUST: Large documentation files should go in a -doc subpackage… N/A
☑ MUST: If a package includes something as %doc… OK
☑ MUST: Header files must be in a -devel package. N/A
☑ MUST: Static libraries must be in a -static package. N/A
☑ MUST: Packages containing pkgconfig(.pc)… N/A
☑ MUST: If a package contains library files with a suffix… N/A
☑ MUST: In the vast majority of cases, devel packages… N/A
☑ MUST: Packages containing GUI applications… N/A
☑ MUST: Packages must not own files or directories already owned by other
packages… OK
☑ MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}… OK
☑ MUST: All filenames in rpm packages must be valid UTF-8. OK

☒ SHOULD: If the source package does not include license text(s) as a separate
file from upstream… NOK

1. The license text is partial: it describes the exception but not the main
license. A GPL text should be joined to the package

☑ SHOULD: The description and summary sections in the package spec file should
contain translations… N/A
☑ SHOULD: The reviewer should test that the package builds in mock. OK
☐ SHOULD: The package should compile and build into binary rpms on all supported
architectures. I pass, but that's a noarch package
☑ SHOULD: The reviewer should test that the package functions as described… OK
☒ SHOULD: If scriptlets are used, those scriptlets must be sane. NOK
Please use :

%post
if [ -x %{_bindir}/fc-cache ]; then 
  %{_bindir}/fc-cache %{_datadir}/fonts
fi

%postun
if [ "$1" = "0" ]; then
  if [ -x %{_bindir}/fc-cache ]; then 
    %{_bindir}/fc-cache %{_datadir}/fonts
  fi
fi

like in other font packages (or request them fixed if %{_bindir} is NOK)

☒ SHOULD: Usually, subpackages other than devel… N/A
☒ SHOULD: The placement of pkgconfig(.pc) files depends on their usecase… N/A
☒ SHOULD: If the package has file dependencies outside of /etc, /bin… N/A

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.