[Bug 239892] Review Request: eclipse-checkstyle - a checkstyle plugin for eclipse

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-checkstyle - a checkstyle plugin for eclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239892





------- Additional Comments From overholt at redhat.com  2007-05-12 07:53 EST -------
I'll take this one.  I won't have time to do a full review until Monday but here
are a few quick thoughts based on a glace at the specfile:

- remove Epoch
- change Group to something else (yes, I know the eclipse package has that one
but run rpmlint on your SRPM and you'll see the W: Wrong Group (or whatever) ...
paste the group error message into rpmlint -I <error message here> and you'll
see acceptable groups.  Just pick one as the Group tag is currently not used for
anything useful but this way we can shut up rpmlint.)
- remove BuildArch
- change the BuildRoot to match the Fedora Guidelines (that may not longer be a
mandatory requirement ... just check the guidelines)
- I think a lot of your BuildRequires can go away if you pick something like
eclipse-pde since it'll bring in most of the others ... building in mock will
help flush out problems here
- we'll have to get some better way to include the Eclipse jars since the names
are so fragile.  For SWT especially you'll have to use a symlinked one (I think
we ship one) and not the x86_64-only one.
- we should add the gcj bits like aot-compile at the end of %install and then
the bits in %files ... but that can easily be added later

Like I said, I'll do a full review on Monday.  I'll assign to myself then.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.