[Bug 239892] Review Request: eclipse-checkstyle - a checkstyle plugin for eclipse

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-checkstyle - a checkstyle plugin for eclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239892


overholt at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |overholt at redhat.com




------- Additional Comments From overholt at redhat.com  2007-05-14 14:58 EST -------
(In reply to comment #2)
> - i believe i implemented all of your suggestions and they successfully built in
> mock with fedora-devel-x86_64-core and fedora-devel-i386-core configurations.

Great!  I'll start the review now.

> - i couldn't find any symlinked jars to use, so i used a wildcard (*) where the
> architecture specific bit of the eclipse jar is.

%{_libdir}/eclipse/eclipse/swt-gtk-3.2{,.2}.jar

> - it would be very nice to be able to write less brittle eclipse plugin
> specfiles.

Agreed, but most don't have this problem if they use PDE build.

> symlinks might be one way to do it, and wildcards might be another
> alternative.  are there other options?

Other than PDE build, I can't think of anything OTTOMH.

> if we can settle on the best way to do
> it we should document that methodology in a "Packaging of add-ons for Eclipse"
> or similar wiki page.

Agreed!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.