[Bug 238233] Review Request: perl-Catalyst-Plugin-ConfigLoader - Load config files of various types

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Plugin-ConfigLoader - Load config files of various types


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238233


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-05-15 01:44 EST -------
I got following message in build.log But I assume its harmless
Cannot determine perl version info from lib/Catalyst/Plugin/ConfigLoader.pm

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
c74052aa2f09d5044eb37aa34a1b89a5  Catalyst-Plugin-ConfigLoader-0.14.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/01-use.t t/10-live_auto.t t/20-mock_load.t
t/98-pod_coverage.t t/99-pod.t
t/01-use.............ok
t/10-live_auto.......t/10-live_auto.t does not exist
t/20-mock_load.......ok
t/98-pod_coverage....ok
t/99-pod.............ok
All tests successful.
Files=5, Tests=11,  1 wallclock secs ( 0.54 cusr +  0.09 csys =  0.63 CPU)
mv 10-live_auto.t t/
exit 0

+ Provides: perl(Catalyst::Plugin::ConfigLoader) = 0.14
+ Requires: perl(:MODULE_COMPAT_5.8.8) perl(Catalyst) perl(Config::Any)
perl(Data::Visitor::Callback) perl(NEXT) perl(strict) perl(warnings)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.