[Bug 239892] Review Request: eclipse-checkstyle - a checkstyle plugin for eclipse
bugzilla at redhat.com
bugzilla at redhat.com
Tue May 15 20:20:59 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: eclipse-checkstyle - a checkstyle plugin for eclipse
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239892
------- Additional Comments From overholt at redhat.com 2007-05-15 16:20 EST -------
Thanks for making the changes!
(In reply to comment #7)
> - sticking with ant for now since i can't get pde build to work
That's cool.
> - some lines just won't go shorter than 80 characters
Understood.
> - ignoring rpmlint symlink warnings since i think build-jar-repository is the
> way to go
Agreed.
> - built in mock fedora-devel-i386-core.cfg fedora-devel-x86_64-core.cfg
Great.
> - works in eclipse
Works for me, too.
I can't duplicate the md5sum of the tarball, but the contents are the same. I'm
not going to hold up the review on this, but I'm curious as to why they're not
the same.
There is just one more thing: remove the epoch from your changelog entries to
shut rpmlint up. Once that's done, this will be ready to go.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list